tpokorra/walletmonitor
1
0
Fork 0
Code Issues 5 Pull Requests Actions Activity

add support to record fees in crypto currency for transactions #28

New Issue
Closed
opened 2021-05-11 06:45:54 +02:00 by Ghost · 1 comment
Ghost commented 2021-05-11 06:45:54 +02:00 (Migrated from codeberg.org)
Copy Link
Copy Source

eg. for moving assets to your personal wallet, there is just a fee in the crypto currency.
eg. for some market places, you pay the fees in crypto or in fiat currency.

see #24

eg. for moving assets to your personal wallet, there is just a fee in the crypto currency. eg. for some market places, you pay the fees in crypto or in fiat currency. see #24
Ghost commented 2021-05-11 06:53:15 +02:00 (Migrated from codeberg.org)
Copy Link
Copy Source

https://github.com/tpokorra/walletmonitor/blob/main/apps/transactions/models.py

we currently have these columns:

  • amount_before_fee (crypto)
  • amount_after_fee (crypto)
  • amount (fiat)

It would be good to change this to:

  • amount_crypto
  • amount_fiat
  • fee_crypto
  • fee_fiat

see data migration: https://docs.djangoproject.com/en/3.2/topics/migrations/#data-migrations

https://github.com/tpokorra/walletmonitor/blob/main/apps/transactions/models.py we currently have these columns: * amount_before_fee (crypto) * amount_after_fee (crypto) * amount (fiat) It would be good to change this to: * amount_crypto * amount_fiat * fee_crypto * fee_fiat see data migration: https://docs.djangoproject.com/en/3.2/topics/migrations/#data-migrations
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
tpokorra (Timotheus Pokorra)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tpokorra/walletmonitor#28